Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tee quote endpoint #588

Closed
wants to merge 125 commits into from
Closed

feat: tee quote endpoint #588

wants to merge 125 commits into from

Conversation

maceip
Copy link
Collaborator

@maceip maceip commented Sep 12, 2024

sgx only, default report data

Copy link
Member

@yuroitaki yuroitaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice stuff, left some comments :)

crates/notary/server/Cargo.toml Outdated Show resolved Hide resolved
crates/notary/server/src/server.rs Outdated Show resolved Hide resolved
crates/notary/server/src/tee.rs Outdated Show resolved Hide resolved
crates/notary/server/src/tee.rs Outdated Show resolved Hide resolved
crates/notary/server/src/tee.rs Outdated Show resolved Hide resolved
crates/notary/server/src/tee.rs Outdated Show resolved Hide resolved
crates/notary/server/src/tee.rs Outdated Show resolved Hide resolved
crates/notary/server/src/tee.rs Outdated Show resolved Hide resolved
crates/notary/server/src/tee.rs Outdated Show resolved Hide resolved
crates/notary/server/src/tee.rs Outdated Show resolved Hide resolved
Copy link
Member

@yuroitaki yuroitaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<ignore this, vs code github plugin bug>

Copy link
Member

@yuroitaki yuroitaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<ignore this, vs code github plugin bug>

.github/workflows/ssh-azure-tee-build.yaml Show resolved Hide resolved
.github/workflows/ssh-azure-tee-build.yaml Outdated Show resolved Hide resolved
.github/workflows/ssh-azure-tee-build.yaml Outdated Show resolved Hide resolved
.github/workflows/ssh-azure-tee-build.yaml Outdated Show resolved Hide resolved
.github/workflows/ssh-azure-tee-build.yaml Outdated Show resolved Hide resolved
.github/workflows/ssh-azure-tee-build.yaml Outdated Show resolved Hide resolved
@maceip
Copy link
Collaborator Author

maceip commented Sep 21, 2024

sgx-build-azure-ssh

forces ephemeral notary key: generates keypair at startup, shares pubkey @ /indfo
hardware measurement data now inside /info endpoint
ci build script pr merged here: janky bash until azure linked properly
replaced intel dcap-sys crate -> mobilecoin dcap types crate for simplicity -- will re-visit for TDX
error handling improved but still 2/10
docker images & artifacts on azure:
    notaryserverbuilds.azurecr.io/sgx/base:latest
    notaryserverbuilds.azurecr.io/sgx/gramine-layer
    notaryserverbuilds.azurecr.io/sgx/tee-notary-server
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 65.05747% with 152 lines in your changes missing coverage. Please review.

Please upload report for BASE (dev@79c00fc). Learn more about missing BASE report.

Files with missing lines Patch % Lines
crates/notary/server/src/tee.rs 0.00% 65 Missing ⚠️
crates/notary/client/src/client.rs 0.00% 17 Missing ⚠️
crates/wasm/src/tests.rs 0.00% 14 Missing ⚠️
crates/core/src/transcript/proof.rs 0.00% 13 Missing ⚠️
crates/core/src/attestation/proof.rs 0.00% 8 Missing ⚠️
crates/wasm/src/types.rs 0.00% 8 Missing ⚠️
crates/notary/server/src/server.rs 0.00% 5 Missing ⚠️
crates/core/src/presentation.rs 0.00% 4 Missing ⚠️
crates/notary/server/src/service.rs 0.00% 4 Missing ⚠️
crates/core/src/merkle.rs 0.00% 2 Missing ⚠️
... and 8 more
Additional details and impacted files
@@          Coverage Diff           @@
##             dev     #588   +/-   ##
======================================
  Coverage       ?   54.24%           
======================================
  Files          ?      192           
  Lines          ?    20518           
  Branches       ?        0           
======================================
  Hits           ?    11130           
  Misses         ?     9388           
  Partials       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maceip maceip requested a review from yuroitaki October 9, 2024 09:06
@maceip maceip closed this Oct 9, 2024
@maceip maceip deleted the quote-presentation branch October 9, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants